-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Command Does Not Include Response Type #253
Comments
Hello @skeggse I'm not sure that I understand the issue - commands.json at its current form does not feature the response type as it is already specified in each command's .md file. |
I opened this six years ago, and have no recollection about the problem I was trying to solve or any additional details. I'll consider this closed. |
Sure - my apologies for the belated reply. |
@itamarhaber, if I recall correctly, my use case was having response types in the JSON so that machines could process them. Specifically, there was a TypeScript library that derived typings from this project so that types could be verified via static analysis at compile time. |
@nl-brett-stime === @skeggse ? Ok, I can see how this could be handy for clients that want to know beforehand about the response's type. Funnily enough, with RESP3 this should be a moot point. Still, it may be worth the effort if only for completeness' sake. |
Reopening this for further consideration |
Yeah this seems reasonable.
Nope! |
Closing as stale. |
commands.json
should include an expected response type for each command. For example,INCR
should have aresponse
property of"integer"
, because under normal operating conditions it responds with a long integer.The text was updated successfully, but these errors were encountered: