Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command Does Not Include Response Type #253

Closed
skeggse opened this issue Jul 31, 2013 · 8 comments
Closed

Command Does Not Include Response Type #253

skeggse opened this issue Jul 31, 2013 · 8 comments

Comments

@skeggse
Copy link

skeggse commented Jul 31, 2013

commands.json should include an expected response type for each command. For example, INCR should have a response property of "integer", because under normal operating conditions it responds with a long integer.

@itamarhaber
Copy link
Member

Hello @skeggse

I'm not sure that I understand the issue - commands.json at its current form does not feature the response type as it is already specified in each command's .md file.

@skeggse
Copy link
Author

skeggse commented Oct 19, 2019

I opened this six years ago, and have no recollection about the problem I was trying to solve or any additional details. I'll consider this closed.

@skeggse skeggse closed this as completed Oct 19, 2019
@itamarhaber
Copy link
Member

Sure - my apologies for the belated reply.

@nl-brett-stime
Copy link

@itamarhaber, if I recall correctly, my use case was having response types in the JSON so that machines could process them. Specifically, there was a TypeScript library that derived typings from this project so that types could be verified via static analysis at compile time.

@itamarhaber
Copy link
Member

@nl-brett-stime === @skeggse ?

Ok, I can see how this could be handy for clients that want to know beforehand about the response's type. Funnily enough, with RESP3 this should be a moot point. Still, it may be worth the effort if only for completeness' sake.

@itamarhaber
Copy link
Member

Reopening this for further consideration

@itamarhaber itamarhaber reopened this Oct 20, 2019
@skeggse
Copy link
Author

skeggse commented Oct 20, 2019

Yeah this seems reasonable.

@nl-brett-stime === @skeggse ?

Nope!

@nermiller
Copy link
Contributor

Closing as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants