Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does the redismod container need to use append only? #72

Closed
simonprickett opened this issue Jan 5, 2022 · 1 comment · Fixed by #85
Closed

Does the redismod container need to use append only? #72

simonprickett opened this issue Jan 5, 2022 · 1 comment · Fixed by #85
Assignees

Comments

@simonprickett
Copy link
Contributor

The Redis server in the redismod container used for runnign tests has an append only file configured. Is this needed?

If not, then this:

services:
  redis:
    image: "redislabs/redismod:edge"
    entrypoint: ["redis-server", "--appendonly", "yes", "--loadmodule", "/usr/lib/redis/modules/rejson.so", "--loadmodule", "/usr/lib/redis/modules/redisearch.so"]
    restart: always
    ports:
      - "6380:6379"
    volumes:
      - ./data:/data

could be updated / simplified to:

services:
  redis:
    image: "redislabs/redismod:edge"
    entrypoint: ["redis-server", "--loadmodule", "/usr/lib/redis/modules/rejson.so", "--loadmodule", "/usr/lib/redis/modules/redisearch.so"]
    restart: always
    ports:
      - "6380:6379"
@simonprickett simonprickett self-assigned this Jan 6, 2022
@simonprickett
Copy link
Contributor Author

This could probably also be swapped out to use the redislabs/redisearch:edge container and we won't need to pass module loading configuration either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant