Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing tests in SREM command (minor issue) #30

Closed
anibal opened this issue Apr 10, 2010 · 2 comments
Closed

Failing tests in SREM command (minor issue) #30

anibal opened this issue Apr 10, 2010 · 2 comments

Comments

@anibal
Copy link

anibal commented Apr 10, 2010

$ rake
Loaded suite /home/anibal/.gem/ruby/1.8/gems/rake-0.8.7/lib/rake/rake_test_loader
Started
..P.P................................................P...P..P.P..P..P...........................F.F.........P..............
Finished in 10.152636 seconds.

  1. Failure:
    test_Does_not_send_extra_commands_on_errors(RedisTest::TestInternals) [./test/redis_test.rb:66]:
    <[]> exception expected but was
    Class:
    Message: <"-ERR wrong number of arguments for 'srem' command">
    ---Backtrace---
    ./test/../lib/redis/client.rb:545:in format_error_reply' ./test/../lib/redis/client.rb:535:informat_reply'
    ./test/../lib/redis/client.rb:474:in read_reply' ./test/../lib/redis/client.rb:444:inprocess_command'
    ./test/../lib/redis/client.rb:442:in map' ./test/../lib/redis/client.rb:442:inprocess_command'
    ./test/../lib/redis/client.rb:431:in raw_call_command' ./test/../lib/redis/client.rb:452:incall'
    ./test/../lib/redis/client.rb:452:in maybe_lock' ./test/../lib/redis/client.rb:428:inraw_call_command'
    ./test/../lib/redis/client.rb:332:in call_command' ./test/../lib/redis/client.rb:381:inmethod_missing'
    ./test/redis_test.rb:67:in `test_Does_not_send_extra_commands_on_errors'

./test/redis_test.rb:66:in `test_Does_not_send_extra_commands_on_errors'

  1. Failure:
    test_Recovers_from_failed_commands(RedisTest::TestInternals) [./test/redis_test.rb:54]:
    <[]> exception expected but was
    Class:
    Message: <"-ERR wrong number of arguments for 'srem' command">
    ---Backtrace---
    ./test/../lib/redis/client.rb:545:in format_error_reply' ./test/../lib/redis/client.rb:535:informat_reply'
    ./test/../lib/redis/client.rb:474:in read_reply' ./test/../lib/redis/client.rb:444:inprocess_command'
    ./test/../lib/redis/client.rb:442:in map' ./test/../lib/redis/client.rb:442:inprocess_command'
    ./test/../lib/redis/client.rb:431:in raw_call_command' ./test/../lib/redis/client.rb:452:incall'
    ./test/../lib/redis/client.rb:452:in maybe_lock' ./test/../lib/redis/client.rb:428:inraw_call_command'
    ./test/../lib/redis/client.rb:332:in call_command' ./test/../lib/redis/client.rb:381:inmethod_missing'
    ./test/redis_test.rb:55:in `test_Recovers_from_failed_commands'

./test/redis_test.rb:54:in `test_Recovers_from_failed_commands'

114 tests, 584 assertions, 2 failures, 0 errors
rake aborted!
Command failed with status (1): [/usr/bin/ruby1.8 -I"lib" "/home/anibal/.ge...]

(See full trace by running task with --trace)

REDIS-RB INFO:

$ git branch

  • master
    $ git remote
    origin
    $ git log -1
    commit 9e43fde
    Author: Damian Janowski damian.janowski@gmail.com
    Date: Thu Apr 8 09:45:45 2010 -0300

    Check for Ruby 1.9 as early as possible.

REDIS INFO:

$ git branch

  • master
    $ git remote -v
    origin git://github.com/antirez/redis.git
    $ git log -1
    commit dae121d9aa38626db9962ff02879b55eb7ca36bf
    Author: antirez antirez@gmail.com
    Date: Sat Apr 10 11:14:11 2010 +0200

    dict.c fixed to play well with enabling/disabling of the hash table

$ ./redis-server
[15568] 10 Apr 08:06:52 # Warning: no config file specified, using the default config. In order to specify a config file use 'redis-server /path/to/redis.conf'
[15568] 10 Apr 08:06:52 * Server started, Redis version 1.3.8
[15568] 10 Apr 08:06:52 # WARNING overcommit_memory is set to 0! Background save may fail under low condition memory. To fix this issue add 'vm.overcommit_memory = 1' to /etc/sysctl.conf and then reboot or run the command 'sysctl vm.overcommit_memory=1' for this to take effect.
[15568] 10 Apr 08:06:52 * DB loaded from disk: 0 seconds
[15568] 10 Apr 08:06:52 * The server is now ready to accept connections on port 6379
[15568] 10 Apr 08:06:53 - DB 0: 3 keys (0 volatile) in 4 slots HT.
[15568] 10 Apr 08:06:53 - 0 clients connected (0 slaves), 568567 bytes in use, 0 shared objects

@djanowski
Copy link
Collaborator

Hey Anibal, yes, I pushed the broken tests because it's a bug in the current implementation. Hopefully will be fixed soon.

@anibal
Copy link
Author

anibal commented Apr 12, 2010

Sorry for the double report! Will scan previous issues better next time ;)

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants