r.keys should retrurn an array

[skaes]

prior to 2.0, r.keys(pattern) returned the matching keys as an array. now it returns a single, blank separated string.

This new behavior breaks our beetle gem. We could work around it, but I consider this as a bug, as keys with embedded blanks seem to be supported by redis.

[antirez]

The server changed return type, I fixed that in 1.x branch and Ezra merged. I guess that with 2.0 this was re-inserted. My fault as I did not wrote regression tests in my patch.

[skaes]

I used redis-rb 2.0.0 against redis 1.2.6.

[soveran]

Fixed in 2.0.1.

[skaes]

unfortunately, it's not fixed:

require 'rubygems'
require 'redis'
r = Redis.new
r.set("a b c", "x")  # ==> "OK"
r.get("a b c")       # ==> "x"
r.keys("*")          # ==> ["a", "b", "c"]

I think this should be ["a b c"], right?

[soveran]

Even if a key with spaces works for all operations, I think it will never work with the keys 1.2.6 because it returns the keys as a space separated string. Sadly, there's no way to determine in that string the beginning and end of keys containing spaces.

The fix included in 2.0.1 assumes keys don't contain spaces, which is the best we can do at this point.

[skaes]

bummer. but thanks a lot for the quick reaction.

[soveran]

You're welcome.

[antirez]

Hey soveran, skaes: my patch checked if the returned value (from the low level decoding function) was an array or a string. If it's a string, just split it. This is the relevant commit:

http://github.com/ezmobius/redis-rb/commit/07579be932511f4fd5598dbbda1f0f154d836c76

I think we should fix this for 2.0.x as well.

Cheers,
Salvatore

[soveran]

antirez: yes, it's already fixed in 2.0.1. The other problem I think has no solution, though.

[antirez]

Sorry misunderstood the chat. The only fix is switching to Redis 2.0 indeed.

Cheers,
Salvatore