Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] "LOLWUT" ASCII art unimplemented in Redis7 #12074

Open
zdzichu opened this issue Apr 19, 2023 · 6 comments
Open

[BUG] "LOLWUT" ASCII art unimplemented in Redis7 #12074

zdzichu opened this issue Apr 19, 2023 · 6 comments
Labels
state:to-be-closed requesting the core team to close the issue

Comments

@zdzichu
Copy link

zdzichu commented Apr 19, 2023

Describe the bug

According to the documentation, LOLWUT command should create a piece of generative computer art. This is unimplemented in version 7.

To reproduce

Issue LOLWUT command with Redis ver 7.x

Expected behavior

Beauty.

Additional information

There are functions lolwut5Command() and lolwut6Command() for previous versions. Yet for version 7 code fallbacks to lolwutUnstableCommand() which outputs textual version representation only. No ASCII Art.

@jakub-m
Copy link

jakub-m commented Apr 19, 2023

I am affected. Please have a look ASAP.

@oranagra
Copy link
Member

OMG what a horrible bug... I guess redis 7.0 is completely useless until that bug is fixed.

Seriously though... we rather invest our time in useful features and improvements.

@oranagra oranagra added the state:to-be-closed requesting the core team to close the issue label Apr 19, 2023
@zuiderkwast
Copy link
Contributor

I think LOLWUT is a fun thing that gives Redis character, though it's understandable that the maintainers can't invest time in it. @zdzichu if you (or someone else) would be willing to contribute a LOLWUT to Redis 8, then I hope there's a change it can be accepted. (Maybe even fix the bug for Redis 7.)

@madolson
Copy link
Contributor

I made one that does Julia fractals with ascii art but never published it. If there is no objection I would finish and publish it. (Maybe I'll do it anyways)

@oranagra
Copy link
Member

I don't have any conceptual objection other than that i think it's not good use of your time.
the other concern is the other overheads (core review, making sure there's no security concerns, and any issues that could surface in the future, like build / sanitizer warnings).

@MakDon
Copy link
Contributor

MakDon commented May 8, 2023

It is also unavailable in https://try.redis.io/
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:to-be-closed requesting the core team to close the issue
Projects
None yet
Development

No branches or pull requests

6 participants