Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Config set maxmemory not return correct result #5504

Open
hongliuliao opened this issue Oct 30, 2018 · 0 comments
Open

[Bug] Config set maxmemory not return correct result #5504

hongliuliao opened this issue Oct 30, 2018 · 0 comments

Comments

@hongliuliao
Copy link
Contributor

hongliuliao commented Oct 30, 2018

the cmd "config set maxmemory 111" run the code like bebind:

image
freeMemoryIfNeeded may run failed , but it return OK

Reappear step:

    1. fill some no ttl keys to redis , maxmemory-policy: volatile-lru
      image
    1. set maxmemory to 200000000, it return OK
    1. we can see warning log like " WARNING: the new maxmemory value set via CONFIG SET is smaller than the current memory usage. This will result in keys eviction and/or inability to accept new write commands depending on the maxmemory-policy" , redis memory usage is not reduce
    1. Because we not set key ttl , so freeMemoryIfNeeded will return C_ERR, i think we need return error for this case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant