Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XSETID incorrect comment regarding argument signature? #5519

Open
coleifer opened this issue Nov 2, 2018 · 2 comments
Open

XSETID incorrect comment regarding argument signature? #5519

coleifer opened this issue Nov 2, 2018 · 2 comments

Comments

@coleifer
Copy link

coleifer commented Nov 2, 2018

See: https://github.com/antirez/redis/blob/edce5150bf56df76fd7ca41c595a63a145550ed8/src/t_stream.c#L1824

The command signature is: XSETID <stream> <groupname> <id>

However the actual implementation seems to be: XSETID <stream> <id>

@itamarhaber
Copy link
Member

Hello @coleifer

This is your first issue here so congrats! Also - so great to have you active in redis-py, hoping to see more of that ;)

@adioanca
Copy link

adioanca commented Apr 3, 2019

This is not so bad... it helped me "solve" my issue: https://stackoverflow.com/questions/55497990/redis-streams-inconsistent-behavior-of-blocking-xread-after-xdel/55504518

Maybe,
... add a new XGROUPSETID for groups...?
... or make [GROUP groupID] optional?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants