Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarification of node address and port in cluster mode #6238

Open
ruben-herold opened this issue Jul 15, 2019 · 1 comment
Open

clarification of node address and port in cluster mode #6238

ruben-herold opened this issue Jul 15, 2019 · 1 comment

Comments

@ruben-herold
Copy link

hi,

we are testing redis cluster in an ipv6 only setup. The cluster it selfs seems to run fine.
But nearly all clients we tried can't work with moved.

The documentation said:

GET x -MOVED 3999 127.0.0.1:6381
Most clients now split "127.0.0.1:6381" with : as delimiter between IP and Port. Or like the stackexchange dotnet client which use the string "127.0.0.1:6381" to connect to. This works
well in an ipv4 only environment. But on IPv6 this will fail.

In the moment redis return:

GET x -MOVED 4844 XXX:XXXX:X:X::1:4:6379

This makes it very hard for the clients to parse it. From my point of view "[XXX:XXXX:X:X::1:4]:6379" would be the better way for IPv6.

@Dragonsangel
Copy link

What is the status of this issue?

We are having similar issues, although with the CLUSTER NODES command returning IPv6 as XXX:XXX:XXX::10:1:6379@26379, which are then parsed incorrectly as IP : XXX:XXX:XXX::10:1:6379, Port: 0, CPort: 26379.

According to RFC 3986, the IPv6 should be represented as [XXX:XXX:XXX::10:1]:6379.
This will allow that all clients can correctly interpret the IPv6 returned, regardless of the command used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants