"dir" directive in configuration cannot be overriden

[eta-orionis]

The "dir" directive from redis.conf cannot be overriden by an included file.

Debian 9.9 stretch
Redis server v=3.2.6 sha=00000000:0 malloc=jemalloc-3.6.0 bits=64 build=a2cab475abc2115e

Steps to reproduce:

1. Install redis from the Debian repository
2. Stop redis service, mv /var/lib/redis to another path, e.g. /data/redis. (/data is 0755, /data/redis keeps its permissions)
3. Add local configuration file /etc/redis/local.conf with contents "dir /data/redis"
4. Add an include line /etc/redis/redis.conf : include /etc/redis/local.conf
5. Try restarting the service. It will crash and complain that it cannot find /var/lib/redis

Other directives in the local.conf file are respected and will override redis.conf, only "dir" is not respected.

[ptjm]

dir changes the working directory of the server. The problem you're having isn't so much that dir can't be overridden as that it takes effect immediately. If you have two dir directives in your config file, the last one will win, but both directories have to exist. Also, any relative paths given in the config file between the two dir directives will be relative to the dir in the first one.