Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Consider adding ACL User to Monitor #6806

Open
IAmATeaPot418 opened this issue Jan 24, 2020 · 2 comments
Open

Enhancement: Consider adding ACL User to Monitor #6806

IAmATeaPot418 opened this issue Jan 24, 2020 · 2 comments

Comments

@IAmATeaPot418
Copy link
Contributor

IAmATeaPot418 commented Jan 24, 2020

What are your thoughts about adding the ACL user to monitor @antirez

I think this information may be useful for those debugging that are leveraging some of the complexity of ACLs. For example, when debugging commands it would be helpful to see the user to help determine if an ACLs command or keyspace restrictions is the culprit. While the error message for acls are very clear, if you are debugging from an application perspective it may be helpful to understand the commands issued & by what user to help with the complexity of access controls.

Thoughts?

@itamarhaber
Copy link
Member

Hello @IAmATeaPot418

Error-generating commands (including NOPERM) are not shown in MONITORs output, so I can't see how it will help in debugging as you've suggested. That said, I think that adding the ACL user to MONITOR is a good idea - we already show the connection details.

Note that this modification will break backward compatibility, so some care is needed to think if/how to resolve this.

@guybe7
Copy link
Collaborator

guybe7 commented Feb 5, 2020

#6832

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants