New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] several tests fail while building redis 6.2.4 #9035
Comments
@ss2 did the previous releases of 6.2 pass the tests cleanly? |
I've only being building it on amd64 so far and just compiled all the versions down to 6.0.9, where failover finally passes. The tests had been only introduced to the package declaration [1] where redis was at 6.0.9. hence the said replication tests would have failed at least since version 6.0.9. I didn't package it then, and don't know more details yet. [1] http://git.savannah.gnu.org/cgit/guix.git/commit/?id=3a1cb921c9209d77ae1af38ef5bfa1620fd99899 |
Sorry, I just realised, that I had only tested from 6.2.0--6.2.3, and 6.0.9 only. But I missed the numbers .10--.13. The Fix from #8967 passes. |
ok great. so we know what's the problem. |
Just a follow up: only the failover test passes. Removing integration/replication[^-] will let the build pass. But if I leave replication[^-] in and remove replication-psync, or replication-4, the test suite will hang at: Just want to be clear about this in case I may have have made the impression that all tests had passed. |
@ss2 so the fix in 8967 only fixed one test, and all the rest still fail? Can you please post the failures (errors) you're getting after applying the mentioned patch. |
I'm so sorry about this confusion now. It may well be that I was getting mixed up with what is working, or not. It looks like, that the build will pass if the four tests are disabled. If I enable failover, the build will sometimes pass. Other times it doesn't. Unfortunately I noticed that the build process sometimes passes and at other times doesn't. Here's the tail end of a build log:
|
@ss2 so just to be clear, this run was with the patch from #8967 and you say that the replication tests are commented?
i wanna see the exact failures, and the full list of failures (if there are any) on the version that has that fix. |
There you go:
|
thanks. so it looks like with that fix, most problems are resolved, but one (replication.tcl) is still present. @YaacovHazan can you please look into that? |
Several tests:
will fail while trying to build redis 6.2.4.
I'm pasting only part of the build log. The relevant part is as follows:
To reproduce this, is the following package declaration used in Guix:
while in Guix the package has been pushed keeping the relevant tests disabled [1].
[1] https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/databases.scm#n2137
The text was updated successfully, but these errors were encountered: