Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client with RueidisOtel missing in README docs #442

Closed
DestroyerAlpha opened this issue Jan 11, 2024 · 6 comments · Fixed by #443
Closed

Client with RueidisOtel missing in README docs #442

DestroyerAlpha opened this issue Jan 11, 2024 · 6 comments · Fixed by #443
Labels
documentation Improvements or additions to documentation

Comments

@DestroyerAlpha
Copy link
Contributor

In README for rueidisotel, we have imported Rueidisotel but we are not using the methods from it to initialise client.

@DestroyerAlpha
Copy link
Contributor Author

Also, @rueian when can we expect new release with connection stats?

@rueian
Copy link
Collaborator

rueian commented Jan 11, 2024

Hi @DestroyerAlpha,

Thank you for catching the error. Would you be willing to correct the README for us as well?

Also, @rueian when can we expect new release with connection stats?

These four metrics were introduced since v1.0.24:

  • rueidis_dial_attempt: number of dial attempts
  • rueidis_dial_success: number of successful dials
  • rueidis_dial_conns: number of connections
  • rueidis_dial_latency: dial latency in seconds

And you have to initialize your client with the rueidisotel.NewClient constructor to instrument them.

@rueian rueian added the documentation Improvements or additions to documentation label Jan 11, 2024
@DestroyerAlpha
Copy link
Contributor Author

Can't seem to find the rueidisotel.NewClient in github.com/redis/rueidis v1.0.25-go1.18.

@rueian
Copy link
Collaborator

rueian commented Jan 11, 2024

Can't seem to find the rueidisotel.NewClient in github.com/redis/rueidis v1.0.25-go1.18.

Oh, rueidisotel.NewClient uses the latest otel which requires go 1.20, therefore it is not available in the -go1.18 and -go1.19 builds.

@DestroyerAlpha
Copy link
Contributor Author

@rueian have raised the PR to fix the documentation issue.

@rueian
Copy link
Collaborator

rueian commented Jan 11, 2024

@rueian have raised the PR to fix the documentation issue.

LGTM. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants