Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove optimization which causes inaccurate results #1052

Merged
merged 1 commit into from Jan 28, 2020

Conversation

ashtul
Copy link
Contributor

@ashtul ashtul commented Jan 28, 2020

Remove usage of optimization which resulted in false results.
Can't find the original algorithm to try and fix.
Should the code of optimization be removed altogether?

@ashtul ashtul changed the title remove wrong optimization remove optimization which causes inaccurate results Jan 28, 2020
@codecov
Copy link

codecov bot commented Jan 28, 2020

Codecov Report

Merging #1052 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1052      +/-   ##
==========================================
- Coverage   83.14%   83.12%   -0.03%     
==========================================
  Files         144      144              
  Lines       18626    18626              
==========================================
- Hits        15487    15482       -5     
- Misses       3139     3144       +5
Impacted Files Coverage Δ
src/aggregate/reducers/quantile.c 63.46% <100%> (ø) ⬆️
src/legacy_gc.c 85.16% <0%> (-3.82%) ⬇️
src/indexer.c 92.88% <0%> (+0.33%) ⬆️
src/util/quantile.c 94% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5379319...31520d4. Read the comment docs.

@mnunberg mnunberg merged commit 382e216 into master Jan 28, 2020
@mnunberg mnunberg deleted the false-quantile-issue branch January 28, 2020 13:57
@emmanuelkeller emmanuelkeller added this to the 1.6.8 milestone Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants