Resolves #1706 BGSAVE takes write lock before forking, inorder to prevent synchroniz… #1709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation or other modification to the graphs while forking.
swilly22
approved these changes
May 19, 2021
swilly22
changed the title
swilly22
added a commit
that referenced
this pull request
May 25, 2021
* Reword error message on setting property value to invalid type (#1691) (cherry picked from commit 7c4ec16) * fixing terraform-version for tests (#1700) (cherry picked from commit d597e04) * compute distinct hash only on projected values (#1703) * compute distinct hash only on projected values * test coverage * avoid multiple calls to Record_GetMappings (cherry picked from commit b363415) * Fix regression in GRAPH.CONFIG GET * (#1708) (cherry picked from commit ea2e6b2) * BGSAVE takes write lock before forking, inorder to prevent synchronization or other modification to the graphs while forking. (#1709) Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> (cherry picked from commit 2aa604f) * set graph sync policy to resize only (#1702) * set graph sync policy to resize only * reset graph sync policy once batch is processed (cherry picked from commit af52040) * ignore bound node when constructing a scan op for it (#1714) (cherry picked from commit 45403aa) * early returns migrated to one place (#1699) * early returns migrated to one place * moving the early_returns (cherry picked from commit 7251258) * check for existance of pdata before freeing func desc (#1715) (cherry picked from commit 972e990) * Fix getterraform script. Updated benchmark dev docs, specs and triggering. (#1693) * [fix] Fix getterraform script. Updated benchmark dev docs, specs and triggering. * [add] .circleci on-integ-and-version-tags matches same rules as other modules * [add] .circleci on-integ-and-version-tags matches same rules as other modules * [fix] Fixed merge conflict on requirements * [add] enforcing --required-module graph * [fix] added missing --setup-prerequisits to ci perf automation [add] locally enforcing --required-module graph * [fix] Fixed typo on benchmark/requirements.txt Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> (cherry picked from commit 0cb693a) * flush matrix only if dirty (#1716) * flush matrix only if dirty * simplified dirty marking (cherry picked from commit 7742afd) * Should take lock before fork only on BGSAVE flow and not RedisSearch GC. (#1712) * Should take lock before fork only on BGSAVE flow and not RedisSearch GC. * Added BGSAVE test. * Added check for bgsave status, and update query to create index. * Taking read lock before lock instead of write lock. * exclude bgsave test when running with valgrind. * perform all CRUD operation when stressing BGSAVE Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> Co-authored-by: swilly22 <roi@redislabs.com> (cherry picked from commit d279f3d) * Update tests-qa-run to support Opereto3 (#1719) * Update tests-qa-run to support Opereto3 * Update run - adding OPERETO3_URL as var Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> (cherry picked from commit f26b9e3) * replicate graph.config set (#1720) (cherry picked from commit de0709e) * bump version to 2.4.5 Co-authored-by: Chayim <chayim@users.noreply.github.com> Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> Co-authored-by: OfirMos <82366525+OfirMos@users.noreply.github.com> Co-authored-by: filipe oliveira <filipecosta.90@gmail.com> Co-authored-by: tomerhekredis <72793005+tomerhekredis@users.noreply.github.com>
swilly22
added a commit
that referenced
this pull request
May 28, 2021
* compute distinct hash only on projected values (#1703) * compute distinct hash only on projected values * test coverage * avoid multiple calls to Record_GetMappings (cherry picked from commit b363415) * BGSAVE takes write lock before forking, inorder to prevent synchronization or other modification to the graphs while forking. (#1709) Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> (cherry picked from commit 2aa604f) * Should take lock before fork only on BGSAVE flow and not RedisSearch GC. (#1712) * Should take lock before fork only on BGSAVE flow and not RedisSearch GC. * Added BGSAVE test. * Added check for bgsave status, and update query to create index. * Taking read lock before lock instead of write lock. * exclude bgsave test when running with valgrind. * perform all CRUD operation when stressing BGSAVE Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> Co-authored-by: swilly22 <roi@redislabs.com> (cherry picked from commit d279f3d) * ignore bound node when constructing a scan op for it (#1714) (cherry picked from commit 45403aa) * bump version to 2.2.17 Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com> Co-authored-by: OfirMos <82366525+OfirMos@users.noreply.github.com>
pnxguide
pushed a commit
to CMU-SPEED/RedisGraph
that referenced
this pull request
Mar 22, 2023
…ation or other modification to the graphs while forking. (RedisGraph#1709) Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ation or other modification to the graphs while forking.