Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

org.redisson.tomcat.RedissonSessionManager renders tomcat8 useless if Redis server is down #1651

Open
larsgv opened this issue Sep 27, 2018 · 2 comments

Comments

@larsgv
Copy link

larsgv commented Sep 27, 2018

Exception thrown if Redis-server is down, causes apps to stop working.
This might be an intended behavior, but the presence of the centralized session backup is not mission critical for our system (only used for failover). But using this session manager will actually introduce a new critical error to our system, when/if the Redis server goes down.

A flag/setting where communication errors with Redis would be logged instead of causing a "crash" would be highly appreciated.

Expected/Wanted behavior

Tomcat uses the local session to service the request and ignores any store/find session issues related to communication with Redis-server.

Actual behavior

An Exception is thrown.

Steps to reproduce or test case

Load a page on tomcat where a session is created and attribute is added to it. Turn of Redis-server and reload the page.

Redis version

3.0.6

Redisson version

3.7.5

Redisson configuration

Manager is set up with readMode="MEMORY" and updateMode="DEFAULT"


singleServerConfig:
address: "redis://localhost:6379"
subscriptionConnectionMinimumIdleSize: 1
subscriptionConnectionPoolSize: 50
connectionMinimumIdleSize: 32
connectionPoolSize: 64
database: 0
dnsMonitoringInterval: 5000
transportMode: "EPOLL"
useLinuxNativeEpoll: true

@mrniko mrniko added the feature label Jan 18, 2019
@qupera
Copy link

qupera commented Sep 2, 2019

Is this feature planned to be implemented? It is very important to us as well. Any feedback on this would be greatly appreciated.
Thx in advance

@mrniko mrniko added the tomcat label Feb 13, 2020
@mrniko mrniko added this to the 3.15.5 milestone Apr 25, 2021
@mrniko mrniko modified the milestones: 3.15.5, 3.15.6 May 13, 2021
@mrniko mrniko modified the milestones: 3.15.6, 3.16.0 Jun 8, 2021
@mrniko mrniko modified the milestones: 3.16.0, 3.16.1 Jun 21, 2021
@mrniko mrniko modified the milestones: 3.16.1, 3.16.2 Jul 26, 2021
@mrniko mrniko modified the milestones: 3.16.2, 3.16.3 Sep 5, 2021
@jglapa
Copy link

jglapa commented Sep 6, 2021

Yes, please. Some kind of graceful handling of temporary redis downtime would be appreciated(maybe fallback to some other session management implementation?) .

When redis goes down or connectivity with it is interrupted whole tomcat blows up serving nasty error pages which cannot be even intercepted. e.g.
image

Users are facing similar problems in other cases e.g. https://stackoverflow.com/questions/62127697/tomcat-not-handling-500-internal-server-code-thrown-by-external-service

@mrniko mrniko modified the milestones: 3.16.3, 3.16.4 Sep 23, 2021
@mrniko mrniko modified the milestones: 3.16.4, 3.16.5 Oct 29, 2021
@mrniko mrniko modified the milestones: 3.16.5, 3.16.6 Nov 30, 2021
@mrniko mrniko modified the milestones: 3.16.6, 3.16.7 Dec 9, 2021
@mrniko mrniko modified the milestones: 3.16.7, 3.16.8 Jan 3, 2022
@mrniko mrniko modified the milestones: 3.16.8, 3.16.9 Jan 25, 2022
@mrniko mrniko removed this from the 3.16.9 milestone Mar 24, 2022
@mrniko mrniko modified the milestones: 3.17.4, 3.17.5 Jun 16, 2022
@mrniko mrniko modified the milestones: 3.17.5, 3.17.6 Jul 26, 2022
@mrniko mrniko modified the milestones: 3.17.6, 3.17.7 Aug 25, 2022
@mrniko mrniko modified the milestones: 3.17.7, 3.17.8 Oct 5, 2022
@mrniko mrniko modified the milestones: 3.18.0, 3.18.1 Nov 11, 2022
@mrniko mrniko modified the milestones: 3.18.1, 3.18.2 Dec 5, 2022
@mrniko mrniko modified the milestones: 3.19.0, 3.19.1 Dec 16, 2022
@mrniko mrniko modified the milestones: 3.19.1, 3.19.2 Jan 6, 2023
@mrniko mrniko modified the milestones: 3.19.2, 3.19.3, 3.19.4 Feb 2, 2023
@mrniko mrniko modified the milestones: 3.19.4, 3.20.1 Mar 2, 2023
@mrniko mrniko modified the milestones: 3.20.1, 3.20.2 Mar 28, 2023
@mrniko mrniko modified the milestones: 3.21.0, 3.21.1 May 1, 2023
@mrniko mrniko modified the milestones: 3.21.1, 3.21.2 May 12, 2023
@mrniko mrniko modified the milestones: 3.21.2, 3.12.x May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants