Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Run Source' shortcut collides with 'Save As...' default binding #55

Closed
albertopessia opened this issue Mar 8, 2018 · 3 comments
Closed
Assignees

Comments

@albertopessia
Copy link

  • VSCode Version: 1.20.1
  • VSCode-R Version: 0.5.4
  • OS Version: Windows 10

Key combination Ctrl + Shift + S is a standard shortcut for 'Save As...' dialog and it is already taken by VS Code. I suggest to use a different combination for 'R: Run Source' because the user might get a different behavior than the one expected.

Thanks for the great extension!

@Ikuyadeu
Copy link
Member

@albertopessia Thank you for using this extension and issue.
I agree your suggestion. However, R Studio users think Ctrl + Shift + S is Run Source.
Sorry, please change setting.json.
I put

TODO: Add Command R: Change shortcut mode

If other users want this function.

@Ikuyadeu Ikuyadeu self-assigned this Mar 12, 2018
@andycraig
Copy link
Collaborator

I’m following up on some old issues. I think changing via setting.json is probably sufficient for users who want Ctrl + Shift + S to be set back to ‘Save As...’.

@Ikuyadeu I’m closing this but please reopen if you want!

@Ikuyadeu
Copy link
Member

@andycraig Thank you for managing issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants