Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: extract secrets path bug fixed #506

Merged
merged 3 commits into from Aug 10, 2021
Merged

Conversation

mojtabaimani
Copy link
Contributor

There was an error extracting secret path after converting bash to typescript in otomi chart. There was always an extra 'properties.' at the beginning of the paths. Now it is fixed.

Copy link
Contributor

@j-zimnowoda j-zimnowoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok but why unites did not discover that bug?

Otomi Container Platform automation moved this from In Review to Closed Aug 10, 2021
@j-zimnowoda j-zimnowoda reopened this Aug 10, 2021
Otomi Container Platform automation moved this from Closed to In Progress Aug 10, 2021
@j-zimnowoda j-zimnowoda merged commit e93c137 into master Aug 10, 2021
Otomi Container Platform automation moved this from In Progress to Done Aug 10, 2021
@delete-merged-branch delete-merged-branch bot deleted the mojtaba/secrets-path branch August 10, 2021 09:53
0-sv pushed a commit that referenced this pull request Aug 21, 2021
* fix: extract secrets path bug fixed

* fix: linter

Co-authored-by: Jehoszafat Zimnowoda <jehoszafat.zimnowoda@redkubes.com>
Ani1357 pushed a commit that referenced this pull request Oct 25, 2023
* fix: extract secrets path bug fixed

* fix: linter

Co-authored-by: Jehoszafat Zimnowoda <jehoszafat.zimnowoda@redkubes.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants