Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: create symbolic link on request to server #564

Merged
merged 7 commits into from Sep 1, 2021
Merged

fix: create symbolic link on request to server #564

merged 7 commits into from Sep 1, 2021

Conversation

j-zimnowoda
Copy link
Contributor

fixes #256

@project-bot project-bot bot added this to In Review in Otomi Container Platform Aug 31, 2021
Morriz
Morriz suggested changes Aug 31, 2021
View reviewed changes
Copy link
Contributor

@Morriz Morriz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope this fixes it. Minor remarks related to dev principles. Like, don't defend against errors (those must surface and be fixed)

src/server/index.ts Outdated Show resolved Hide resolved
@j-zimnowoda
Copy link
Contributor Author

It is not defending but postponed check.

@Dunky13
Copy link
Contributor

Dunky13 commented Sep 1, 2021

Could it be that the server is started before a symlink is created?
https://github.com/redkubes/otomi-core/pull/564/files#diff-e4e7a68d82cdfba4e7dab9a32a8f55f3806ffa0cf33f1b8ab64b42941cf68888L61-L63

@Morriz
Copy link
Contributor

Morriz commented Sep 1, 2021

great...tnx

@Morriz Morriz merged commit 3688fb8 into master Sep 1, 2021
Otomi Container Platform automation moved this from In Review to Done Sep 1, 2021
@delete-merged-branch delete-merged-branch bot deleted the envDir branch September 1, 2021 09:10
@RafMo20D RafMo20D mentioned this pull request Jun 22, 2023
Merged
@Nikusharoot Nikusharoot mentioned this pull request Sep 9, 2023
Open
Ani1357 pushed a commit that referenced this pull request Oct 25, 2023
@j-zimnowoda
fix: create symbolic link on request to server (#564)
36f52a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Morriz Morriz Morriz approved these changes

@Dunky13 Dunky13 Dunky13 approved these changes

@mojtabaimani mojtabaimani Awaiting requested review from mojtabaimani

@0-sv 0-sv Awaiting requested review from 0-sv

Assignees
No one assigned
Labels
None yet
Projects
Otomi Container Platform
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The git diff return error while using in values repo
3 participants
@j-zimnowoda @Dunky13 @Morriz