Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitlab v3 -> v4 api possible solution #34

Closed
thomas955 opened this issue Jul 17, 2018 · 11 comments
Closed

Gitlab v3 -> v4 api possible solution #34

thomas955 opened this issue Jul 17, 2018 · 11 comments

Comments

@thomas955
Copy link
Collaborator

thomas955 commented Jul 17, 2018

Hi,

after digging a bit into, i discovered to change v3 api namespace to v4 only is not enough. (#31)
I also had to change the return from get_id former "id". "id" is the global issue ID and not the project related "iid". So this "id" and cannot be used if any issue was created in gitlab before. Otherwise it will raise an exception cause, the issue_url["id"] is pointing to the global id number and not to the corresponding project issue id.

How do i can create a pull request directly? I dont want to fork this project again.

@scambra
Copy link
Contributor

scambra commented Jul 18, 2018

pull requests needs to fork, you can edit file in github to send pull request and it will create fork, or you can fork, clone, push to new branch and then create pull request

@thomas955
Copy link
Collaborator Author

Ok ill do so.
I currently try to fix --keep-id also, maybe will take some more time.

@scambra
Copy link
Contributor

scambra commented Jul 18, 2018

You have access, so you can push without sending pull request now

@sdinot
Copy link

sdinot commented Aug 3, 2018

I am facing this issue. Is there any news about it?

@thomas955
Copy link
Collaborator Author

#35

Im currently doing my migration too, and still testing if all things work like expected.
This pull request should help you, nearly the same things i fixed in my version.

@sdinot
Copy link

sdinot commented Aug 3, 2018

Thanks a lot. The code provided by the pull request almost works (issues are created), but the users match fails. I just opened an issue about it #36.

@sdinot
Copy link

sdinot commented Aug 9, 2018

Finally, the code provided in the pull request works fine. The reason of the fail was a wrong Redmine API key as I explained it in #36.

@flashpixx
Copy link

Is there any timeline to integrate the pull request into the current master branch?

@nelo-digitalagentur
Copy link

+1

@AdamN1
Copy link

AdamN1 commented Nov 21, 2019

Please check master branch it should work with gitlab api v4

@HontoNoRoger
Copy link

Can probably be closed as well after #46 is done?
This should fix the problem for people coming here and installing the tool with pip.

@scambra scambra closed this as completed Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants