Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Console topic UI to indicate that retention.bytes is per-partition, not per topic #1010

Open
hcoyote opened this issue Jan 17, 2024 — with Slack · 4 comments

Comments

Copy link

hcoyote commented Jan 17, 2024

We seem to get questions on a frequent enough basis about the disparity between retention.bytes as configured and the total size of a topic as viewed in Console. Can we get the UI annotated to indicate that retention.bytes is the per-partition retention and not the overall topic bytes retention?

I know I've fielded this a few times for customers, and Josh Purcell had one today.

Slack Message

@hcoyote
Copy link
Author

hcoyote commented Jan 17, 2024

image

Red arrow is where I'm talking about. The disparity between the 10GB retention.bytes value that applies to the individual partition and the 134GB actual topic content size is what causes confusion.

@twmb twmb added the frontend label Jan 18, 2024
@weeco weeco added the ui/ux label Jan 20, 2024
@weeco
Copy link
Contributor

weeco commented Jan 20, 2024

Under the configurations tab each config is explained (there's a help tooltip for each config that explains it in more detail). There are more catches with retention enforcement such as knowing about active/inactive segments etc. So not sure what we need to do more than this, but I'll leave it to @mo-redpanda & @ivpanda

@ivpanda
Copy link

ivpanda commented May 7, 2024

If we field this question frequently enough, it means that customers probably aren't seeing that explanation. Would it help to do any of the following:

  • Add a tooltip indicating this is per partition
  • Show the actual retention.bytes (e.g. if there are 3 partitions, show 30GB)?

@hcoyote what do you think? What information do users actually need from this?

@weeco
Copy link
Contributor

weeco commented May 8, 2024

Show the actual retention.bytes (e.g. if there are 3 partitions, show 30GB)?

This is not a good idea, since the majority probably knows that all such configs (segment.bytes, retention.bytes etc) are applied per partition and not per topic this would confuse the majority that understood and did not complain about this setting.

Add a tooltip indicating this is per partition

Personally I'm not a fan of tooltips if it's possibly to avoid them. So wondering if we can just fix it by showing a per partition hint. I suggested the following as part of the message viewer improvements, what do you think?

ss-vsHRaVLn@2x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants