Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy buttons not working #137

Closed
yiskaneto opened this issue Oct 16, 2020 · 12 comments · Fixed by #139
Closed

Copy buttons not working #137

yiskaneto opened this issue Oct 16, 2020 · 12 comments · Fixed by #139
Assignees
Labels
bug Something isn't working frontend

Comments

@yiskaneto
Copy link

Hello Kowl team,

I noticed that when trying to copy the key value from a message the copy buttons don't work, you click on the buttons but nothing happens, I used the latest stable versions of Firefox and Chrome:
image

  • Esca
@weeco weeco added the frontend label Oct 17, 2020
@weeco
Copy link
Contributor

weeco commented Oct 26, 2020

Hi @escanoru ,
I just checked the copy buttons using the version at master. Copy buttons seem to work for me. What version do you use?

Should I take care of something specific to reproduce this?

@yiskaneto
Copy link
Author

Hi @weeco ,

I just realized I don't know where to check the version, I guess this is the version:
image

Anyway, let me deploy the latest version and I'll let you know.

  • Esca

@yiskaneto
Copy link
Author

yiskaneto commented Oct 27, 2020

Hi @weeco,

Kafka Version: 2.4.0

Kowl connects to my cluster and works pretty well, I tried to copy the key value from one of the messages using the latest docker image and the result is the same, I may be missing something, I'm attaching a gif that shows what I'm doing

Kowl_Copied_Buttons

  • Esca

@weeco
Copy link
Contributor

weeco commented Oct 27, 2020

Thanks for the details. Can you share what Browser you are using? I tried with Google Chrome, maybe it's just not compatible with all Browsers.

@yiskaneto
Copy link
Author

OS: Windows 10
Browsers tested:
- Chrome version: 86.0.4240.111
- Firefox version 82.0.1 (64-bit)

@weeco weeco added the bug Something isn't working label Oct 27, 2020
@nilsroehrig
Copy link
Contributor

I was not able to reproduce the issue yet, but I will try it again using Windows next.

@yiskaneto
Copy link
Author

Hi @nilsroehrig,

Maybe I'm missing something, is there any condition that needs to be met before trying to copy the key or values?

-- Esca

@weeco
Copy link
Contributor

weeco commented Oct 28, 2020

@escanoru No you did everything right. Most of our test topics are actually JSON formatted, maybe that's the culprit. Could you take a look at the dev console and see if there are some error logs in the console?

I think testing non JSON encoded messages is the next thing we should test with the Copy buttons :-).

@nilsroehrig
Copy link
Contributor

I think I know what the issue is. Do you run Kowl in an SSL-enabled environment? If not, the root cause lies within browser restrictions. That's because modern browsers do not allow access to the computers clipboard in unsecure environments. Can you confirm that you see an error message like Uncaught TypeError: can't access property "writeText", navigator.clipboard is undefined in your browsers dev console when using one of the copy buttons?

@yiskaneto
Copy link
Author

Hi!

Console output:
image

Kowl_Copied_Buttons

console.log

@nilsroehrig
Copy link
Contributor

@escanoru Thanks, that confirms my assumption above. For now, we don't have a solution to copy stuff from insecure connections, due to mentioned browser restrictions. But we will release a patch soon, avoiding silent fails like you experienced.

@yiskaneto
Copy link
Author

That makes sense, thank you Kowl team!

@weeco weeco closed this as completed in #139 Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants