Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protobuf Git Config: BaseDirectory & Depth #277

Open
MaxBoeh opened this issue Nov 4, 2021 · 3 comments · May be fixed by #814
Open

Protobuf Git Config: BaseDirectory & Depth #277

MaxBoeh opened this issue Nov 4, 2021 · 3 comments · May be fixed by #814
Labels
backend feature New feature or request help wanted Good for newcomers

Comments

@MaxBoeh
Copy link

MaxBoeh commented Nov 4, 2021 •
edited

We are using the protobuf-git configuration as described at https://cloudhut.dev/docs/features/protobuf#git-repository
In our repository the proto-files live within a proto directory, which seems to be very common, and contains 5 levels of nested folders.

Currently KOWL searches only the first 5 levels of the checkout for .proto files, so our last level is not considered.

  • Please add a BaseDirectory config property within protobuf.git.repository config, similar to the other git-based configurations. (I've overlooked, that this is already done and only the release is pending)
  • Please make the 5 levels of folders searched for .proto files configurable.

Thank you very much!
@weeco weeco added backend feature New feature or request help wanted Good for newcomers labels Nov 6, 2021
@weeco
Copy link
Contributor

weeco commented Nov 6, 2021

Hi @MaxBoeh ,
you are right it already exists, but as far as I can see it's not yet documented.

Do you want to submit a PR for your request of making the maxDepth configurable?

@MaxBoeh
Copy link
Author

MaxBoeh commented Nov 9, 2021

Hi @weeco,

As I've never wrote a single line of Go, I don't feel like I'm the right person to participate in this one.

However I've found some details while considering participating:

  • When loading proto files directly from the filesystem (not via git), they seem to be loaded with infinite depth. The loading mechanic looks very similar to the code loading proto files from the git checkout.
  • The Git.Config used in Proto.Config is also used in different parts of the configuration, so it wouldn't make much sense to place a maxDepth-configuration, only responsible for proto-files, there (also it would be ambiguous with git's depth-configuration).

=> To keep an intuitive configuration, streamlining the loading behavior of proto files (using infinite depth) seems the best option to me. However I don't think I'm capable of doing this myself

@omeraha
Copy link

omeraha commented Jun 13, 2022

I'd also be glad to make the levels (depth) configurable, at least for git repositories

@chorin1 chorin1 linked a pull request Aug 18, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend feature New feature or request help wanted Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

backend: configurable maxDepth for git repositories chorin1/console
3 participants
@MaxBoeh @weeco @omeraha