-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
excessive polling for geerlinguy.node_exporter can trigger Github ratelimits #120
Comments
Looks like if node_exporter_version is undefined or |
Added a PR to fix upstream: geerlingguy/ansible-role-node_exporter#21 |
I'm not currently seeing this behavior @hcoyote @tmgstevens. If this is still an issue LMK, otherwise I will close this issue out. |
it'll happen if you repeatedly run ansible in a short period of time. I've hit it pretty frequently. |
I've yet to replicate this issue while running ansible pretty frequently, including in CI testing where multiple clusters are being built simultaneously. What level of frequency are we talking? |
rate limits are low for non-logged in operations. rate limits may also be different if you're operating from within githubs infrastructure, or in relation to CI things. I don't know. But I know that if I curl from my ip address more than 60 times in an hour then the API rate limit gets triggered. And that's not that hard to trigger with repeated ansible runs from multiple hosts, each running multiple curl operations throughout a run.
|
Looks like
geerlingguy.node_exporter
may somehow trigger rate limiting on Github's side because the module checks for the latest version each time ansible runs. We need to figure out if there's a way to disablethis limitingthe frequency of checking.The text was updated successfully, but these errors were encountered: