redpanda: configmap refactors #1357
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commits includes the following additions: * For statement handler in transpiler * operand handlers in transpiler for * modulo * great or equal * less or equal * handle until buildin function in AST tree * add buildin functions to helmette * regexReplaceAll * toYaml * first * trimSuffix * min * semverCompare * fix tiered storage enabled conditions check * add validation test that compares Redpanda chart version 5.8.5 with new implementation
This commit encapsulates the oft repeated logic of how to check `.Enabled` into a collection of `.IsEnabled` methods on their respective structs. When defaulting is required, `IsEnabled` will "ask for" access to the appropriate structures via parameters.
This commit refactors the listener (`_api` and `_api_tls` redpanda.yaml stanzas) into methods on their respective listener structs.
RafalKorepta
force-pushed
the
rk/gh-1202/move-configmap-to-go
branch
6 times, most recently
from
933db92
to
9ef78e3
Compare
|
I incorporated all improvements from this PR into #1268 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two commits encapsulate some of the more difficult checks of
Enabledfields and migrates most config generation onto the listener structs. This is in preparation for allowing customization of thetruststore_file.