-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
redpanda: convert NOTES.txt to go #1403
Conversation
I believe it's the difference of running
|
Huh... Those should be the same 🤔 |
I found small problem
|
It could be reproduced by
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why imports should be changed. Never the less LGTM
+++ b/charts/redpanda/values_partial.gen.go
@@ -6,7 +6,7 @@
package redpanda
import (
- cmmetav1 "github.com/cert-manager/cert-manager/pkg/apis/meta/v1"
+ cmmeta "github.com/cert-manager/cert-manager/pkg/apis/meta/v1"
I'm not sure about the import thing either. It seems to come and go as I run the code generation; I can't fathom why. |
I didn't add the Ci machinery to compare a whole raft of (pretty much identical) NOTES.txt output, just ran it locally.
The
_example-commands.tpl
script calls into the gotohelm functions now.