Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redpanda: convert NOTES.txt to go #1403

Merged
merged 1 commit into from
Jul 3, 2024
Merged

redpanda: convert NOTES.txt to go #1403

merged 1 commit into from
Jul 3, 2024

Conversation

jan-g
Copy link
Contributor

@jan-g jan-g commented Jul 2, 2024

I didn't add the Ci machinery to compare a whole raft of (pretty much identical) NOTES.txt output, just ran it locally.

The _example-commands.tpl script calls into the gotohelm functions now.

@RafalKorepta
Copy link
Contributor

https://github.com/redpanda-data/helm-charts/actions/runs/9760792194/job/26940439905?pr=1403#step:5:359

I believe it's the difference of running nix develop -c 'task ci:lint' or nix develop -c 'gofumpt -w .'

task: [ci:lint] gofumpt -w .
task: [ci:lint] git diff --exit-code
diff --git a/charts/redpanda/notes.go b/charts/redpanda/notes.go
index 05d11b2..8099fe9 100644
--- a/charts/redpanda/notes.go
+++ b/charts/redpanda/notes.go
@@ -149,7 +149,6 @@ func Notes(dot *helmette.Dot) []string {
 			``,
 			fmt.Sprintf(`  %s`, RpkACLCreate(dot)),
 		)
-
 	}
 	notes = append(notes,
 		``,
task: Failed to run task "ci:lint": exit status 1

@chrisseto
Copy link
Contributor

I believe it's the difference of running nix develop -c 'task ci:lint' or nix develop -c 'gofumpt -w .'

Huh... Those should be the same 🤔

@RafalKorepta
Copy link
Contributor

I found small problem

2024-07-02T14:09:16.2034506Z >>> helm install redpanda-pfzd2eoqxt charts/redpanda --namespace redpanda-pfzd2eoqxt --wait --values charts/redpanda/ci/96-audit-logging-values.yaml --timeout 600s --set=image.tag=
2024-07-02T14:09:16.3989941Z Error: INSTALLATION FAILED: YAML parse error on redpanda/templates/tests/test-kafka-sasl-status.yaml: error converting YAML to JSON: yaml: line 45: could not find expected ':'

https://github.com/redpanda-data/helm-charts/actions/runs/9762101576/job/26944710395?pr=1403#step:16:6299

@RafalKorepta
Copy link
Contributor

It could be reproduced by

helm template charts/redpanda --namespace redpanda-pfzd2eoqxt --values charts/redpanda/ci/96-audit-logging-values.yaml.tpl
Error: YAML parse error on redpanda/templates/tests/test-kafka-sasl-status.yaml: error converting YAML to JSON: yaml: line 45: could not find expected ':'

Copy link
Contributor

@RafalKorepta RafalKorepta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why imports should be changed. Never the less LGTM

https://github.com/redpanda-data/helm-charts/actions/runs/9775423743/job/26985777471?pr=1403#step:5:361

+++ b/charts/redpanda/values_partial.gen.go
@@ -6,7 +6,7 @@
 package redpanda
 
 import (
-	cmmetav1 "github.com/cert-manager/cert-manager/pkg/apis/meta/v1"
+	cmmeta "github.com/cert-manager/cert-manager/pkg/apis/meta/v1"

@jan-g
Copy link
Contributor Author

jan-g commented Jul 3, 2024

I'm not sure about the import thing either. It seems to come and go as I run the code generation; I can't fathom why.

@jan-g jan-g merged commit 4275f32 into main Jul 3, 2024
41 checks passed
@jan-g jan-g deleted the gotohelm-notes-v2 branch July 3, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants