Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SVG sprite sheets for icons #134

Closed
ethanwu10 opened this issue Mar 28, 2020 · 0 comments · Fixed by #137
Closed

Use SVG sprite sheets for icons #134

ethanwu10 opened this issue Mar 28, 2020 · 0 comments · Fixed by #137
Assignees
@ethanwu10
Labels
enhancement New feature or request
Projects
Frontend

Comments

@ethanwu10
Copy link
Member

ethanwu10 commented Mar 28, 2020 •
edited
Loading

(pulled out of #131)

Is your feature request related to a problem? Please describe.
Currently, each icon inlines the entire SVG for the icon, resulting in duplication when the same icon is used multiple times

Describe the solution you'd like
Use SVG sprite sheets for our SVG loader - most likely we will use this loader, and an example is included for generating React components automatically (which is what happens with our current config using preact-svg-loader)
@ethanwu10 ethanwu10 added the enhancement New feature or request label Mar 28, 2020
@ethanwu10 ethanwu10 added this to to-do in Frontend via automation Mar 28, 2020
This was referenced Mar 28, 2020
Merged
Merged
@ethanwu10 ethanwu10 self-assigned this Mar 28, 2020
@chen-robert chen-robert moved this from to-do to done in Frontend Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ethanwu10 ethanwu10

Labels
enhancement New feature or request
Projects
Frontend
  
done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use SVG sprites for icons redpwn/rctf
1 participant
@ethanwu10