Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass in success to toasts, but restyle #212

Closed
chen-robert opened this issue Apr 24, 2020 · 1 comment
Closed

Pass in success to toasts, but restyle #212

chen-robert opened this issue Apr 24, 2020 · 1 comment
Labels
refactoring Improve code quality
Projects
Frontend

Comments

@chen-robert
Copy link
Member

Cirrus success styling on toasts looks really bad, but we should pass it in as toast({ type: 'success' }) to retain the semantic meaning.

To alleviate the styling issue, we should override the styles on the success Cirrus toast class with something that is not neon green.

We may need to refactor other parts of the codebase to pass in success for what is semantically a "success" too.
@chen-robert chen-robert added good first issue Good for newcomers refactoring Improve code quality labels Apr 24, 2020
@chen-robert chen-robert added this to to-do in Frontend via automation Apr 24, 2020
@ethanwu10 ethanwu10 removed the good first issue Good for newcomers label Jul 2, 2020
@chen-robert
Copy link
Member Author

Closed by #388

Frontend automation moved this from to-do to done Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring Improve code quality
Projects
Frontend
  
done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ethanwu10 @chen-robert