Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashes on iOS 12 or older devices #74

Closed
1 task
AyonAB opened this issue Jan 15, 2020 · 6 comments · Fixed by #75
Closed
1 task

Crashes on iOS 12 or older devices #74

AyonAB opened this issue Jan 15, 2020 · 6 comments · Fixed by #75
Labels

Comments

@AyonAB
Copy link
Contributor

AyonAB commented Jan 15, 2020

🐛 Bug Report

Crashes on older iOS devices because of the use of iOS Semantic Colors (SystemBackgroundColor, LabelColor etc.). There should be a checking of iOS version.

Objective-C exception thrown. Name: NSInvalidArgumentException Reason: +[UIColor systemBackgroundColor]: unrecognized selector sent to class 0x11ac07ec0

Reproduction steps

Update to latest version, use ProgesssHUD and run on any iOS 12 or below simulator or device

Configuration

Visual Studio for Mac
Xamarin.iOS

Version: 1.3.0

Platform:

  • 📱 iOS
@Cheesebaron
Copy link
Collaborator

Ah! Sorry for that.

@AyonAB do you have time to fix it in a Pull Request?

@AyonAB
Copy link
Contributor Author

AyonAB commented Jan 15, 2020

Sure, can do that.

@Cheesebaron
Copy link
Collaborator

@AyonAB that would be much appreciated.

I guess we should check either if the selector is available or iOS version is met.

@AyonAB AyonAB mentioned this issue Jan 15, 2020
4 tasks
@AyonAB
Copy link
Contributor Author

AyonAB commented Jan 15, 2020

@Cheesebaron done. Review the PR when you can.

@Cheesebaron
Copy link
Collaborator

@AyonAB thanks! Will have a look!

@Cheesebaron
Copy link
Collaborator

I've made a new release 1.3.1 with your fix. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants