Fix: opts.groups.output return undefined

reducejs · Feb 29, 2016 · 6c32f75 · 6c32f75
1 parent c30dd73
commit 6c32f75
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 12 deletions.
diff --git a/lib/groups.js b/lib/groups.js
@@ -97,6 +97,7 @@ class Groups extends Transform {
     if (typeof opts.output === 'function') {
       return function (file) {
         let ret = opts.output(file)
+        if (!ret) return
         ret = path.resolve(basedir, ret)
         // Make sure the returned path is always relative to basedir
         return path.relative(basedir, ret)

diff --git a/test/groups.js b/test/groups.js
@@ -64,7 +64,7 @@ test('groupFilter.output', function(tt) {
       groupFilter: filter,
     })
     groups.once('groups', function (groupsMap) {
-      t.same(groupsMap.size, 3)
+      t.same(groupsMap.size, 2)
       t.same(
         sort(groupsMap.get('A.js')),
         [
@@ -79,10 +79,6 @@ test('groupFilter.output', function(tt) {
           '/path/to/src/page/B/index.js',
         ]
       )
-      t.same(
-        sort(groupsMap.get('C.js')),
-        ['/path/to/node_modules/C/index.js']
-      )
       t.end()
     })
     source().pipe(groups)
@@ -95,9 +91,6 @@ test('groupFilter.output', function(tt) {
     if (/B/.test(file)) {
       return 'B.js'
     }
-    if (/C/.test(file)) {
-      return 'C.js'
-    }
   }))
 
   tt.test('string', run.bind(null, [
@@ -109,10 +102,6 @@ test('groupFilter.output', function(tt) {
       filter: '**/B/index.js',
       output: 'B.js',
     },
-    {
-      filter: '**/C/index.js',
-      output: 'C.js',
-    },
   ]))
 
   tt.end()