Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra character "-" in generated link to private repo makes URL 404 #15

Closed
feegloo opened this issue Nov 30, 2020 · 3 comments
Closed

Comments

@feegloo
Copy link

feegloo commented Nov 30, 2020

When I generate link to my private GitLab repo with "Copy Web Link to File", there is extra "-" character between repo name and "blob", which makes URL 404. Of course, I can manually delete "-".

Example:

https://gitlab2.ams.creativecdn.net/ai-lab/incrementality-suite/-/blob/master/package.json

should be:

https://gitlab2.ams.creativecdn.net/ai-lab/incrementality-suite/blob/master/package.json

--

I use below settings.json:

"gitweblinks.gitLabEnterprise": [
    {
        "baseUrl": "https://gitlab2.ams.creativecdn.net",
        "sshUrl": "git@gitlab2.ams.creativecdn.net"
    }
]
@reduckted
Copy link
Owner

Hi, thanks for the bug report. What edition and version of GitLab are you using? The community edition that I've set up for myself uses URLs with the "-". For example, http://localhost:8080/gitlab-instance-c7f59d2e/monitoring/-/blob/master/README.md

I'm not too familiar with GitLab, so perhaps there's a configuration option that I have set differently to your instance.

@feegloo
Copy link
Author

feegloo commented Dec 1, 2020

GitLab Community Edition 11.7.0

Perhaps there is URL rewriting setup on server (in company I work in) or my GitLab version is not up-to-date (private server)
https://gitlab.com/gitlab-org/quality/performance/-/issues/216 <= maybe its this

Any additional setting to fix this problem would be great.

@feegloo
Copy link
Author

feegloo commented Jan 20, 2021

Seems to work fine in GitLab Community Edition 13.7.4

@feegloo feegloo closed this as completed Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants