Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isPristine fails if object is a Date #278

Closed
box-turtle opened this issue Nov 15, 2015 · 4 comments
Closed

isPristine fails if object is a Date #278

box-turtle opened this issue Nov 15, 2015 · 4 comments

Comments

@box-turtle
Copy link

I believe that the isPristine() check fails if the passed initial and new values are both Dates. If both values are Dates it always returns true.

Object.keys(date) returns an empty array, and so the check to iterate the keys and compare them always returns true.

Maybe add another check for initial instanceof Date?

@erikras
Copy link
Member

erikras commented Nov 15, 2015

Good bug report. Thanks. Will address asap.

@erikras
Copy link
Member

erikras commented Nov 16, 2015

Fixed in v3.0.8. Thanks again.

@box-turtle
Copy link
Author

Thanks Erik!

@lock
Copy link

lock bot commented Jun 3, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants