Memoize validation

[erikras]

Look to reselect for inspiration.

[johanneslumpe]

Haven't looked at reselect, but couldn't we just check whether the passed in data object is a new one? And if it's not just return the last error state.

[erikras]

I think so. I don't know if reselect is doing anything smarter than === or not.

[johanneslumpe]

It seems that by default they do just that - ===. But they allow passing of a custom function. So maybe the first step could be to just use ===.

[erikras]

PRs accepted. ;-)

[johanneslumpe]

I thought so ;) Will try to do something tomorrow morning :)

[johanneslumpe]

@erikras sorry didn't have the time yet, did not forget about this!

[erikras]

I've decided that this is not in the scope of this project. It's the job of the person passing the validation function to memoize it. I've written a library called lru-memoize to enable this in react-redux-universal-hot-example.

[johanneslumpe]

Oh ok, also cool 👍

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.