Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConnectedFieldArray.js uses "includes" which is unsupported in IE11 #3533

Closed
andokai opened this issue Oct 17, 2017 · 5 comments
Closed

ConnectedFieldArray.js uses "includes" which is unsupported in IE11 #3533

andokai opened this issue Oct 17, 2017 · 5 comments
Labels

Comments

@andokai
Copy link
Contributor

andokai commented Oct 17, 2017

Are you submitting a bug report or a feature request?

What is the current behavior?

IE11 blows up when visiting a form that uses a FieldArray

What is the expected behavior?

IE11 shouldn't blow up

Sandbox Link

What's your environment?

Form v7.1.1
IE11

Other information

TypeError: Object doesn't support property or method 'includes'

@andokai
Copy link
Contributor Author

andokai commented Oct 17, 2017

Swapping in thisValue.indexOf(val) !== -1 for thisValue.includes(val) and IE11 no longer blows up.

@gustavohenke
Copy link
Collaborator

Thanks for the report! Would you like to send a PR to fix this?

@andokai
Copy link
Contributor Author

andokai commented Oct 17, 2017

Will do it tomorrow, cheers!

@erikras
Copy link
Member

erikras commented Oct 25, 2017

Fix published in v7.1.2.

@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants