Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormSection propType doesn't allow React 16 Fragment #3859

Closed
lexanth opened this issue Feb 23, 2018 · 5 comments
Closed

FormSection propType doesn't allow React 16 Fragment #3859

lexanth opened this issue Feb 23, 2018 · 5 comments

Comments

@lexanth
Copy link

lexanth commented Feb 23, 2018

Are you submitting a bug report or a feature request?

Bug report

What is the current behavior?

FormSection prop type doesn't allow React 16 Fragment

What is the expected behavior?

FormSection prop type allows React 16 Fragment to be used (PropTypes.node)

Sandbox Link

https://codesandbox.io/s/l6nx50r3m
Open the console

What's your environment?

React 16.2.0
Redux form 7.2.3

Workaround

Wrap Fragment in a Stateless Functional Component
(Everything works, it just adds a console warning)

@gustavohenke
Copy link
Collaborator

Thanks for the report! Issue up for grabs, shouldn't be difficult to fix.

@shulcsm
Copy link

shulcsm commented May 7, 2018

Perhaps use Fragment as default? It's breaking change but it doubt many people use it.

@gustavohenke
Copy link
Collaborator

@shulcsm it would definitely break many people's code.

@erikras
Copy link
Member

erikras commented Jun 12, 2018

Fix released in v7.4.0.

@lock
Copy link

lock bot commented Jun 12, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants