Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated lifecycle hooks are being used in redux-form #4510

Closed
beqaweb opened this issue Jul 23, 2019 · 3 comments · Fixed by #4520
Closed

Deprecated lifecycle hooks are being used in redux-form #4510

beqaweb opened this issue Jul 23, 2019 · 3 comments · Fixed by #4520
Labels
enhancement improvements in current API next relating to next major release

Comments

@beqaweb
Copy link

beqaweb commented Jul 23, 2019

The issue:

Both componentWillReceiveProps and componentWillMount are deprecated and will be removed from the next major release of React while they are being used by Field, Form.

What is the current behavior?

Currently, react native shows yellow box warnings and it is very annoying having to dismiss those warning every time.
Screen Shot 2019-07-23 at 11 38 46 AM

My environment

I'm using redux-form@^8.2.4 (react-native@0.60.3)

The question is, are those lifecycle hooks going to be replaced with right api's provided by new react?

Because, I guess in the future, after those hooks will be removed from react, I will get errors from redux-form like "componentWillReceiveProps is not a function" or something similar.

Thanks for providing such a nice form library. Looking forward for your respond.
@renatoagds renatoagds added this to the v9.0.0 milestone Jul 30, 2019
@renatoagds renatoagds added enhancement improvements in current API next relating to next major release labels Jul 30, 2019
@czabaj
Copy link
Contributor

czabaj commented Aug 12, 2019 •
edited

Shall I send PR with all deprecated lifecycle methods renamed to UNSAFE_..., it will at least silence the warnings.

@tomek-f
Copy link

tomek-f commented Aug 12, 2019

Shall I send PR with all deprecated lifecycle methods renamed to UNSAFE_..., it will at least silence the warnings.

Yes, please :)

@czabaj czabaj mentioned this issue Aug 12, 2019
Merged
@renatoagds
Copy link
Contributor

Published in v8.2.6.

@snyk-bot snyk-bot mentioned this issue Mar 22, 2020
Closed
@snyk-bot snyk-bot mentioned this issue Apr 9, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement improvements in current API next relating to next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: rename unsafe lifecycle methods to silence console warnings
4 participants
@tomek-f @renatoagds @beqaweb @czabaj