Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redux-form's actions don't conform to FSA #586

Closed
stevengoldberg opened this issue Jan 23, 2016 · 4 comments
Closed

redux-form's actions don't conform to FSA #586

stevengoldberg opened this issue Jan 23, 2016 · 4 comments

Comments

@stevengoldberg
Copy link

A Flux Standard Action (FSA):

MUST

  • be a plain JavaScript object.
  • have a type property.

An action MAY

  • have a error property.
  • have a payload property.
  • have a meta property.

An action MUST NOT include properties other than type, payload, and error, and meta.

redux-form's actions don't conform to this standard -- many of them have several additional properties, but no payload.

This caused me some confusion when I was trying to have one of my other reducers respond to a redux-form action, but I was getting an undefined parameter in my handler -- my createReducer function was only passing action.payload to the handler method, because I was expecting every action to follow FSA, as all of my app's internal actions do.

@erikras
Copy link
Member

erikras commented Jan 23, 2016

I would accept a PR if it's that important to you.

@ooflorent
Copy link
Contributor

Addressed by #799

@erikras
Copy link
Member

erikras commented May 4, 2016

FSA compliance is now published in v6.0.0-alpha-7.

@lock
Copy link

lock bot commented Jun 3, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants