Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status of this project #102

Closed
jay-jlm opened this issue Jul 30, 2017 · 8 comments
Closed

Status of this project #102

jay-jlm opened this issue Jul 30, 2017 · 8 comments

Comments

@jay-jlm
Copy link

jay-jlm commented Jul 30, 2017

Hi,

It would be great if you could share your outlook on the future of this project, I noticed that there have been no new releases since the initial batch.
Cheers.

@Noitidart
Copy link

Agreed, I'm having a nasty bug and no comments from the project contributors after posting issues. It seems to have died before it got started.

@sorodrigo
Copy link
Member

We are maintaining a fork, what kind of bug did you encountered? @Noitidart

@fabriziomoscon
Copy link
Contributor

@sorodrigo waiting for #99 to be merged we have also made the fix able on npm under a different name: @anyjunk/redux-offline doing so you would NOT need to commit lib under git, because the source will be build before you publish to npm. We found that this is a very clean way to use the fork with a minimum difference from master.

@Noitidart
Copy link

Thanks @sorodrigo ! I am actually using redux-thunk with it, and am noticing if I don't do a setTimeout in a multiple dispatch then sometimes I get double redux-offline action, as seen here - #23 (comment)

Then the other thing is, for some reason, in react-native, the fetch breaks if its within a redux-offline dispatch and it hangs forever on await res.text() here - #103 - I can't explain this one at all. The way I worked around it it is by using a custom config.effect with XMLHttpRequest. Even if I use fetch in my custom config.effect it hangs forever on await res.text() which is nuts.

@sorodrigo
Copy link
Member

@Noitidart hey I don't really get #23, and in #103 it would be useful to see what does getEffect does. I haven't encountered any problem using fetch with redux-offline maybe there's an issue in your implementation.

@fabriziomoscon I agree it's a cleaner approach, right now we're pulling directly from our master branch in the package.json I guess eventually we'll make it available through the npm registry. Cheers!

@adamscybot
Copy link

I'd be interested to hear where the authors see this project going.

I'm going to cc @jevakallio right now. I know this is a little annoying -- please feel free to lock if you have no insight!

I'd love to contribute to this as I think the base idea is good.

@sorodrigo
Copy link
Member

Hello!! I wanted to follow up this issue with the following link: https://github.com/redux-offline/redux-offline . More info at #117 . We will start reviewing the pending PRs because there's good content here waiting yo be merged. Also if anyone is interested in contributing to make this amazing lib better, feel free to drop at the thread I shared above or ping any of the current contributors. ✌️

@fabriziomoscon
Copy link
Contributor

@sorodrigo thank you for the invitation to collaborate with the project. But I have already too much on my plate at the moment and I would not be as active as a collaborator as the project deserves. I think I have to kindly decline the offer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants