Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitBooks #1469

Closed
Andarist opened this issue Jun 4, 2018 · 16 comments · Fixed by #2159
Closed

Update GitBooks #1469

Andarist opened this issue Jun 4, 2018 · 16 comments · Fixed by #2159

Comments

@Andarist
Copy link
Member

Andarist commented Jun 4, 2018

I've noticed that redux' docs got a nice lifting, thanks for the new version of GitBook. Would be nice to upgrade too.

Redux commit introducing the change - reduxjs/redux@b307091

We might want to postpone merging this though, because we don't want to update docs before releasing v1 and from what I understand new Gitbook comes with auto-releases.

@feichao93
Copy link
Member

I'm interested in working on this.

@divyanshu013
Copy link
Contributor

I think this would be a good improvement to the docs. I followed the above pr, seems like there are issues with gitbook. Have you explored other options like docnasaurus or gatsby? Perhpas they could work well. Thoughts?

@Andarist
Copy link
Member Author

@divyanshu013 they would certainly work well - but they would require quit a bit of work initially to setup, Im afraid that we don't have time resources to do that right now. Would you be willing to work on it? My personal choice out of those 2 would be gatsby

@divyanshu013
Copy link
Contributor

@Andarist I also lean towards gatsby. I can surely pick it up but can't promise a timeline (apologies), if you're okay with it.

Any references for docs you have in mind? Gatsby themselves have a good docs site, for reference.

@Andarist
Copy link
Member Author

@Andarist I also lean towards gatsby. I can surely pick it up but can't promise a timeline (apologies), if you're okay with it.

No problem, it's just an enhancement - we are not in a hurry :)

Any references for docs you have in mind? Gatsby themselves have a good docs site, for reference.

Not really - something rather standard, similar to what we currently have.

@divyanshu013
Copy link
Contributor

Awesome, will keep you posted 🙂

@acdvs
Copy link
Contributor

acdvs commented Feb 7, 2021

It looks like the GitBook CLI isn't supported anymore since the team moved to a paid service. Is there still interest in moving the docs to another platform?

@Andarist
Copy link
Member Author

Andarist commented Feb 7, 2021

@acdvs yes! would u like to help with the move?

@acdvs
Copy link
Contributor

acdvs commented Feb 8, 2021

@Andarist Absolutely! I recommend we use Docusaurus for its simplicity and current use in related projects like Redux and React Native but I wouldn't be opposed to something else.

@Andarist
Copy link
Member Author

Andarist commented Feb 8, 2021

I would be OK with Docusaurus 👍 Ideally we'd preserve current URLs - but if that's too hard then I won't treat this as a blocker.

@acdvs
Copy link
Contributor

acdvs commented Feb 8, 2021

The only way to have docs/ at the base of every URL would be to move the docs directory entirely, so we'd either do that or have to settle with URL changes.

@Andarist
Copy link
Member Author

Andarist commented Feb 8, 2021

What do u mean by moving the docs directory entirely? As to the directory structure in this repository - we have complete freedom for making changes in it.

@acdvs
Copy link
Contributor

acdvs commented Feb 8, 2021

Ok, I just wasn't sure what the preferable option was there. I guess it would be much better to keep the same URL structure for SEO purposes.

Something in the current site that isn't possible with Docusaurus is having the base readme as the "home" page. The home page would either need to be (1) a real home page (like the Redux site has) or (2) an existing doc in the docs directory (e.g., docs/introduction/BeginnerTutorial.md).

I think option one with a true homepage is far better in the long run but would require some work to fill it out properly.

@Andarist
Copy link
Member Author

Andarist commented Feb 8, 2021

A "real" home page sounds good - although I don't have the capacity to work on the design and such. Would you be able to help out with this?

@acdvs
Copy link
Contributor

acdvs commented Feb 8, 2021

I can absolutely write some initial content for it. I'm sure other people will have good suggestions to improve on it later.

@Andarist
Copy link
Member Author

Andarist commented Feb 8, 2021

Super, that's going to be awesome 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants