-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can we safely drop the Symbols support? #126
Comments
FYI this is the original thread where we decided to adopt Symbol support. |
You can put somewhere a "patch" so anyone can adopt "Symbal" supoprt if they need it. I personally don't know any project who uses Symbols. |
I'm curious to see if there are any use cases for Symbols before just dropping them. From the Redux docs:
but it might make more sense for FSA to "standardize" on strings only for the advantages mentioned. |
If we are unsure about it, I think it's okay to keep it. It doesn't do anything harmful. |
@timche I agree - I think it makes a better candidate for the next major version to be dropped. We can mark it as deprecated for now and see if there's pushback. It also shouldn't block this release any more than it has :) |
With v1.0.0 we would also like to drop the Symbols support as they are not recommended and "generally a bad idea".
Before we are dropping it completely, is anyone using them extensively?
The text was updated successfully, but these errors were encountered: