Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename noopCheck to identityFunctionCheck #2090

Closed
aryaemami59 opened this issue Dec 2, 2023 · 1 comment
Closed

Rename noopCheck to identityFunctionCheck #2090

aryaemami59 opened this issue Dec 2, 2023 · 1 comment
Milestone

Comments

@aryaemami59
Copy link
Contributor

What is the new or updated feature that you are suggesting?

Rename noopCheck to identityFunctionCheck

Why should this feature be included?

  • To provide a more accurate description since a no-op function is more like () => {}, an identity function is like x => x.
  • It would also be more consistent with the definitions defined in Reselect.

What docs changes are needed to explain this?

The No-op selector check section will have to be slightly tweaked.

https://react-redux.js.org/api/hooks#no-op-selector-check

@EskiMojo14 EskiMojo14 added this to the 9.0 milestone Dec 2, 2023
@EskiMojo14
Copy link
Collaborator

adding the 9.0 milestone as this would be a breaking change :)

I personally don't have any objections to the change though - we'd have to add it to the migration guide, but I suspect the amount of people impacted would be low

@timdorr timdorr closed this as completed Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants