Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shallow equal does not check for property existance in B #601

Closed
maxired opened this issue Jan 19, 2017 · 1 comment
Closed

Shallow equal does not check for property existance in B #601

maxired opened this issue Jan 19, 2017 · 1 comment

Comments

@maxired
Copy link

maxired commented Jan 19, 2017

Hey,

in the current implementation of shallow equal, we don't check for the key to exist in the B object.
This can lead to bug, in case some values are undefined.

For example

shallowEqual( { a: undefined}, { bb: 2} )

currnetly return true instead of false.
On can check this by pulling maxired@6de3fc5

Following #590 , I agree that it might be a good option to switch to a more robust implementation

@maxired
Copy link
Author

maxired commented Jan 19, 2017

#591 should close this one

@timdorr timdorr closed this as completed Feb 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants