Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expected identifier error in IE8 #45

Closed
kevana opened this issue Dec 28, 2015 · 6 comments
Closed

Expected identifier error in IE8 #45

kevana opened this issue Dec 28, 2015 · 6 comments

Comments

@kevana
Copy link

kevana commented Dec 28, 2015

At line 6:

exports.default = thunkMiddleware;

default is a reserved keyword in IE8 and it throws an errror when dot notation is used. it does work when bracket notation is used:

exports['default'] = thunkMiddleware;

I think this is a bug in the upstream babel-plugin-add-module-exports, but wanted to show it here in case people are looking here first.
@kevana kevana closed this as completed Dec 28, 2015
@kevana kevana reopened this Dec 28, 2015
@kevana kevana changed the title Expected identifier in IE8 Expected identifier error in IE8 Dec 28, 2015
@gaearon
Copy link
Collaborator

gaearon commented Dec 28, 2015

Please let us know if it doesn't get resolved soon and we need to work around it.

@kevana
Copy link
Author

kevana commented Dec 28, 2015

Will do. I'm using the string-replace-webpack-plugin to work around it for now.

@gaearon
Copy link
Collaborator

gaearon commented Dec 28, 2015

This should be fixed in 4.0.6.
Please verify.

@gaearon gaearon closed this as completed Dec 28, 2015
@gaearon
Copy link
Collaborator

gaearon commented Dec 28, 2015

Sorry, wrong repo.

@gaearon gaearon reopened this Dec 28, 2015
@gaearon
Copy link
Collaborator

gaearon commented Dec 28, 2015

Should be fixed in 1.0.3.
Please verify?

@gaearon gaearon closed this as completed Dec 28, 2015
@kevana
Copy link
Author

kevana commented Dec 29, 2015

Verified fixed, thanks.

@kwarr128 kwarr128 mentioned this issue Jan 5, 2016
Merged
@snyk-bot snyk-bot mentioned this issue Mar 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gaearon @kevana