Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate RSK to "Redux Toolkit" #248

Closed
markerikson opened this issue Nov 12, 2019 · 3 comments
Closed

Migrate RSK to "Redux Toolkit" #248

markerikson opened this issue Nov 12, 2019 · 3 comments

Comments

@markerikson
Copy link
Collaborator

@markerikson markerikson commented Nov 12, 2019

Following up from #246 :

Tasks

  • New redux-toolkit.js.org domain name
    • Ask for instructions on handling the switch ( js-org/js.org#3532 )
    • Follow steps for changing over
    • Ensure new redux-toolkit.js.org name points to the site
    • Ensure current redux-starter-kit.js.org name redirects or points to the new site
  • Publish the new package name
    • Rename package in package.json
    • Rename Github repo
    • Change URL of repo
    • Update README
    • Update UMD global variable name to RTK
    • Publish new version
    • Merge in new docs site
  • Force people to migrate to the new package
  • Update docs content
    • Rewrite all the docs content to scrub and update the package name, the actual name, and the abbreviations
    • Re-create / update tutorial sandboxes and repos using new package name
  • Come up with a single "sales pitch" description line. I've been using multiple variations in different places, and it would be nice to have something short, descriptive, and consistent.
  • Update other Redux docs
    • Redux core docs (front link and content)
    • React-Redux docs (front link)
  • Update other content
  • General announcements
@nickmccurdy

This comment has been minimized.

Copy link
Collaborator

@nickmccurdy nickmccurdy commented Dec 1, 2019

I'd recommend using npm deprecate rather than throwing an error, as the package manager will be able to deal with the warnings at build time and the data will be machine readable.

Also, should we add the "formerly known as Redux Starter Kit" to the home page? I feel like people could be mislead by the new site branding and think it's unrelated.

@markerikson

This comment has been minimized.

Copy link
Collaborator Author

@markerikson markerikson commented Dec 1, 2019

I did npm deprecate as soon as I published RTK for the first time. React Testing Library did the "publish a new version with an error message" thing, so there's precedent. (I think they specifically did it as a major for react-testing-library, which is probably the nicer way to handle it.)

https://redux-starter-kit.js.org still exists as a domain name, but it points to the same Netlify server, so I would hope that would kind of be a clue :)

@markerikson

This comment has been minimized.

Copy link
Collaborator Author

@markerikson markerikson commented Dec 26, 2019

Just published RSK 2.0, which removes all the code and throws the "migrate to RTK" error message:

https://github.com/reduxjs/redux-toolkit/releases/tag/v1.0.4

That wraps things up here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.