Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTK Query examples broken due to misformatted tsconfig.json files #4185

Closed
jacklin213 opened this issue Feb 12, 2024 · 2 comments · Fixed by #4190
Closed

RTK Query examples broken due to misformatted tsconfig.json files #4185

jacklin213 opened this issue Feb 12, 2024 · 2 comments · Fixed by #4190

Comments

@jacklin213
Copy link

jacklin213 commented Feb 12, 2024

Commit b0ce4df in #4135 ended up formatting tsconfig.json files throughout the repo and appended trailing , which is not valid JSON.

This is causing examples in code sandbox on https://redux-toolkit.js.org/rtk-query/usage/examples to fail with

Error
We weren't able to parse: '/tsconfig.json': Parse error on line 18:
...  "noEmit": true,  },}
----------------------^
Expecting 'STRING', got '}'

Suggest to exclude any .json files from being formatted with trailing commas

@jacklin213 jacklin213 changed the title RTK Query examples broken RTK Query examples broken due to misformatted tsconfig.json files Feb 12, 2024
@markerikson
Copy link
Collaborator

/cc @aryaemami59 - can you reformat these?

@aryaemami59
Copy link
Contributor

@markerikson Yes sir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants