Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing loose-envify dependency #1304

Closed
dereklieu opened this issue Jan 28, 2016 · 11 comments
Closed

Missing loose-envify dependency #1304

dereklieu opened this issue Jan 28, 2016 · 11 comments

Comments

@dereklieu
Copy link

Hey, thanks for the awesome work on redux.

Just installed 3.1.1. package.json calls for a loose-envify transform, but it's not listed as a dependency anywhere and so is breaking my build.

@gaearon
Copy link
Contributor

gaearon commented Jan 28, 2016

Argh :-(

I thought this might be a problem but didn't verify. Can you make a PR to add it please? Same for React Redux.

@gaearon
Copy link
Contributor

gaearon commented Jan 28, 2016

I'm in a car now but I'll be able to release a fix in about half an hour.

@timdorr
Copy link
Member

timdorr commented Jan 28, 2016

@gaearon I'll get things together short of the npm publish for you.

@gaearon
Copy link
Contributor

gaearon commented Jan 28, 2016

Thanks!

@dereklieu
Copy link
Author

Thanks @timdorr @gaearon!

@timdorr
Copy link
Member

timdorr commented Jan 28, 2016

Should this be a regular dependency or devDep?

@gaearon
Copy link
Contributor

gaearon commented Jan 28, 2016

It seems like it should be a regular dep. I think React does it that way.

@timdorr
Copy link
Member

timdorr commented Jan 28, 2016

Because this is our first and only regular dependency, which seems a little odd. shrug

@gaearon
Copy link
Contributor

gaearon commented Jan 28, 2016

Fixed in 3.1.2.

@gaearon
Copy link
Contributor

gaearon commented Jan 28, 2016

I deprecated the faulty versions of redux and react-redux.
Please verify whether the fixes worked!

@dereklieu
Copy link
Author

Not using react-redux in this project so can't speak to that, but built successful with redux@3.1.2. Thanks for turning this around so speedily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants