Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Server Rendering guide due to the changes in the Counter example #2211

Closed
forketyfork opened this issue Jan 19, 2017 · 5 comments
Closed
Labels

Comments

@forketyfork
Copy link

The Server Rendering guide refers to the Counter example to demonstrate adding SSR to a redux application. However, the Counter example was refactored since it was originally mentioned in the guide:

  • It no longer includes the App container which is used in the guide,
  • It was refactored to run with react-scripts without the server part. Adding a server side to this example now requires more work than is described in the guide.

While still providing the basic understanding of how to add SSR to a redux project, the guide now cannot be followed step-by-step, and probably needs to be rewritten using a different example.

@markerikson
Copy link
Contributor

Yeah, we've had a few people point out that there's some places where the tutorials in the docs don't match the example projects. I don't think any of us maintainers have time to make changes to those right now, but if you'd like to submit some PRs that fix things up, that would definitely be appreciated.

@ioboi
Copy link

ioboi commented Feb 14, 2017

I’d like to update the Server Rendering recipe. Instead of using the Counter example, I thought of using the Todo List example as a base guide.

@markerikson Hi, what do you think about this idea?

@markerikson
Copy link
Contributor

@ioboi : yeah, if you're interested, we'd definitely work with you to get updates into the docs.

@dominicbales
Copy link

So rewrite a counter App that is SSR? is that what needs to be done along with explaining SSR

@ioboi
Copy link

ioboi commented May 6, 2018

I don't have the time anymore, sombody else can take the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants