Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storeKeys[store[key]] isn't working if all stores wrapped by createStore #35

Closed
vslinko opened this issue Jun 4, 2015 · 4 comments
Closed

storeKeys[store[key]] isn't working if all stores wrapped by createStore #35

vslinko opened this issue Jun 4, 2015 · 4 comments

Comments

@vslinko
Copy link
Contributor

vslinko commented Jun 4, 2015

I think Function.prototype.toString() smells isn't good
@vslinko
Copy link
Contributor Author

vslinko commented Jun 4, 2015

https://github.com/gaearon/redux/blob/09f8aaee981ef19bb7342b7728f750e131249cb5/src/createDispatcher.js#L79

@gaearon
Copy link
Contributor

gaearon commented Jun 4, 2015

Oh man. I totally meant to use get and set of ES6 Map instead.

@gaearon gaearon closed this as completed in 2befd9d Jun 4, 2015
@gaearon
Copy link
Contributor

gaearon commented Jun 4, 2015

Should be good in 0.6.1, can you verify?

@vslinko
Copy link
Contributor Author

vslinko commented Jun 4, 2015

Yep, works well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vslinko @gaearon