Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs Rewrite] Meta-Issue: Redux Toolkit section #3614

Closed
3 tasks done
markerikson opened this issue Nov 12, 2019 · 5 comments
Closed
3 tasks done

[Docs Rewrite] Meta-Issue: Redux Toolkit section #3614

markerikson opened this issue Nov 12, 2019 · 5 comments
Labels
Milestone

Comments

@markerikson
Copy link
Contributor

markerikson commented Nov 12, 2019

This is a tracking issue to cover all work related to adding a miniature version of the RTK docs to the Redux core docs.

Concept

The idea is to specifically document RTK within the core Redux docs, in the same way that we have information on using React-Redux in the core. First suggested here: reduxjs/redux-toolkit#246 (comment) .

For simplicity, I think we should probably just copy-paste most or all of the API docs and the "Usage Guide" page, but not the tutorials. We can point to the main RTK docs site for those. Or, perhaps we could have sidebar links that just point directly to the RTK docs pages. Some of that may require waiting for an upgrade to Docusaurus v2.

Tasks

  • Determine which portions of the RTK content should be available in the Redux core docs
  • Determine approach for copying or linking content
  • Add content
@markerikson
Copy link
Contributor Author

Paging the Docusaurus folks: @wgao19 , @endiliey , @yangshun .

Can we add external links to the sidebar in DS v1, or just in v2?

@yangshun
Copy link
Contributor

Hmm I don't think so. @endiliey could we backport this feature? Since it's available in v2 and the API is the same.

@endiliey
Copy link
Contributor

endiliey commented Nov 12, 2019

Sorry but I think adding this to v1 back isnt that easy although lot of API in v2 stays the same, the underlying code is very different (its a re-write after all). I am hesitant to add it back to v1 since there’s almost no tests in v1 on that part and it could cause regression. (In v2 we have 100% test coverage on docs functionality so regression is harder).

@markerikson
Copy link
Contributor Author

markerikson commented Nov 16, 2019

Okay. Maybe for now we should just have a small section with an "Overview" page, and link to the RTK docs pages from that page. Could also add a single-page miniature version of the RTK API reference.

@markerikson markerikson changed the title [Docs Rewrite] Meta-Issue: Redux Starter Kit section [Docs Rewrite] Meta-Issue: Redux Toolkit section Nov 16, 2019
@markerikson
Copy link
Contributor Author

markerikson commented Nov 16, 2019

Settled on just adding an "Overview" page for now that reuses some of the text from the RTK "Getting Started" page to describe what RTK is and why you should use it. I added links to the individual RTK API reference pages at the bottom.

That should suffice for now. I'll close this, and we can re-open it if we feel there's more work to be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants