Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot Reload Actions #782

Closed
ronag opened this issue Sep 23, 2015 · 8 comments
Closed

Hot Reload Actions #782

ronag opened this issue Sep 23, 2015 · 8 comments
Labels

Comments

@ronag
Copy link

ronag commented Sep 23, 2015

Anyone done any work or have any ideas on hot reloadable actions?

este/este#482

@gaearon
Copy link
Contributor

gaearon commented Sep 23, 2015

They should work out of the box.

@gaearon gaearon closed this as completed Sep 23, 2015
@gaearon
Copy link
Contributor

gaearon commented Sep 23, 2015

(With Webpack Hot Module Replacement, updates to stateless modules "bubble up" until some module handles them. In case of action creators, updates will bubble to components, which are handled by react-transform-hmr.)

@steida
Copy link

steida commented Sep 23, 2015

@gaearon Can you point us to any starter kit, where actions are hot reloadable? I tried some without success.

@gaearon
Copy link
Contributor

gaearon commented Sep 23, 2015

Examples folder in this project should work.

@gaearon
Copy link
Contributor

gaearon commented Sep 23, 2015

Oh, I see now. This got broken after the switch from React Hot Loader to React Transform (#690). The reason for this is that babel-plugin-react-transform has no idea examples/counter/containers/App.js is a component, and doesn't enable hot reloading for it. Same goes for other examples.

Since this is an issue unrelated to Redux, please track it in gaearon/babel-plugin-react-transform#26. You can also keep using React Hot Loader until it is fixed. With React Hot Loader, action creators should get reloaded just fine.

@gaearon
Copy link
Contributor

gaearon commented Feb 29, 2016

You might be interested in #1455.

@gaearon
Copy link
Contributor

gaearon commented Apr 18, 2016

This is fixed in React Hot Loader 3.
It is built with lessons learned from both React Hot Loader and React Transform.
It’s still in alpha but I encourage you to check it out!

@steida
Copy link

steida commented Apr 18, 2016

Awesome work Dan, you are the man :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants