Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discussion] Multiple code coverage report comments #488

Closed
eXamadeus opened this issue Feb 9, 2021 · 2 comments
Closed

[Discussion] Multiple code coverage report comments #488

eXamadeus opened this issue Feb 9, 2021 · 2 comments

Comments

@eXamadeus
Copy link
Contributor

eXamadeus commented Feb 9, 2021 •
edited

Multiple code coverage reports are used in PRs

Reselect should probably only have one. Right now it's using both Coveralls and Codecov.io. It appears that Coveralls was not running for some time and is the source of most of the duplicates.

Unless there are dissenting opinions, I suggest we remove the Coveralls action from the workflow and leave the only coverage reporter to be Codecov.io.

Spawned from comment: @markerikson in #486 (comment)

Side note: why are we getting three different code coverage report comments? :)
@eXamadeus eXamadeus mentioned this issue Feb 9, 2021
Merged
3 tasks
@eXamadeus eXamadeus changed the title Multiple code coverage report comments [Discussion] Multiple code coverage report comments Feb 9, 2021
@markerikson
Copy link
Contributor

Sounds good to me!

@markerikson
Copy link
Contributor

I killed these sometime back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@markerikson @eXamadeus